Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch build testing to Java 21 #499

Merged
merged 4 commits into from
Aug 20, 2024
Merged

Switch build testing to Java 21 #499

merged 4 commits into from
Aug 20, 2024

Conversation

denis-yuen
Copy link
Member

@denis-yuen denis-yuen commented Aug 8, 2024

Description
Switch testing to Java 21. Will probably switch jar later as we gain experience
Unblocked with https://github.com/dockstore/dockstore-deploy/pull/794

Review Instructions
Builds succeed. Support programs like topic sentence generation, submission, metrics, etc. should just work. Could login to the deployer and run them, display help, etc.

Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-6611

Security
If there are any concerns that require extra attention from the security team, highlight them here.

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that you pass the basic style checks and unit tests by running mvn clean install in the project that you have modified (until https://ucsc-cgl.atlassian.net/browse/SEAB-5300 adds multi-module support properly)
  • Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
  • If you are changing dependencies, check with dependabot to ensure you are not introducing new high/critical vulnerabilities
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.

@denis-yuen denis-yuen self-assigned this Aug 8, 2024
@denis-yuen
Copy link
Member Author

denis-yuen commented Aug 8, 2024

Hmmm, need equivalent of https://github.com/dockstore/dockstore/pull/5297/files to pull out all the system rules

Found simpler, if uglier solution

Copy link

sonarcloud bot commented Aug 8, 2024

Copy link

codecov bot commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.13%. Comparing base (da37df9) to head (60c8f7e).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #499   +/-   ##
==========================================
  Coverage      45.13%   45.13%           
- Complexity       305      306    +1     
==========================================
  Files             47       47           
  Lines           2663     2663           
  Branches         205      205           
==========================================
  Hits            1202     1202           
  Misses          1368     1368           
  Partials          93       93           
Flag Coverage Δ
metricsaggregator 36.91% <ø> (ø)
toolbackup 23.16% <ø> (ø)
tooltester 17.31% <ø> (ø)
topicgenerator 19.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@denis-yuen denis-yuen changed the title Switch build, note blocked on deployer Switch build to Java 21, note blocked on deployer Aug 13, 2024
@denis-yuen denis-yuen marked this pull request as ready for review August 19, 2024 20:18
@denis-yuen denis-yuen changed the title Switch build to Java 21, note blocked on deployer Switch build to Java 21 Aug 19, 2024
@denis-yuen denis-yuen changed the title Switch build to Java 21 Switch build testing to Java 21 Aug 19, 2024
@denis-yuen denis-yuen requested review from a team, david4096, kathy-t and hyunnaye and removed request for a team August 19, 2024 20:19
@denis-yuen denis-yuen merged commit f22d65c into develop Aug 20, 2024
11 checks passed
@denis-yuen denis-yuen deleted the feature/java_21 branch August 20, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants