-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch build testing to Java 21 #499
Conversation
Found simpler, if uglier solution |
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #499 +/- ##
==========================================
Coverage 45.13% 45.13%
- Complexity 305 306 +1
==========================================
Files 47 47
Lines 2663 2663
Branches 205 205
==========================================
Hits 1202 1202
Misses 1368 1368
Partials 93 93
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Description
Switch testing to Java 21. Will probably switch jar later as we gain experience
Unblocked with https://github.com/dockstore/dockstore-deploy/pull/794
Review Instructions
Builds succeed. Support programs like topic sentence generation, submission, metrics, etc. should just work. Could login to the deployer and run them, display help, etc.
Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-6611
Security
If there are any concerns that require extra attention from the security team, highlight them here.
Please make sure that you've checked the following before submitting your pull request. Thanks!
mvn clean install
in the project that you have modified (until https://ucsc-cgl.atlassian.net/browse/SEAB-5300 adds multi-module support properly)