Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

little clarification for docs #502

Merged
merged 2 commits into from
Sep 19, 2024
Merged

little clarification for docs #502

merged 2 commits into from
Sep 19, 2024

Conversation

denis-yuen
Copy link
Member

@denis-yuen denis-yuen commented Sep 17, 2024

Description
Add a little bit of documentation during review

Review Instructions
n/a

Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-5953

Security
None

  • Check that you pass the basic style checks and unit tests by running mvn clean install in the project that you have modified (until https://ucsc-cgl.atlassian.net/browse/SEAB-5300 adds multi-module support properly)
  • Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
  • If you are changing dependencies, check with dependabot to ensure you are not introducing new high/critical vulnerabilities
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.

@denis-yuen denis-yuen self-assigned this Sep 17, 2024
@denis-yuen denis-yuen changed the title little clarification little clarification for docs Sep 17, 2024
Copy link

sonarcloud bot commented Sep 17, 2024

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.70%. Comparing base (0381ffd) to head (62d3864).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #502   +/-   ##
==========================================
  Coverage      45.70%   45.70%           
  Complexity       319      319           
==========================================
  Files             50       50           
  Lines           2700     2700           
  Branches         210      210           
==========================================
  Hits            1234     1234           
  Misses          1375     1375           
  Partials          91       91           
Flag Coverage Δ
metricsaggregator 36.70% <ø> (ø)
toolbackup 22.85% <ø> (ø)
tooltester 17.07% <ø> (ø)
topicgenerator 20.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@denis-yuen denis-yuen marked this pull request as ready for review September 17, 2024 17:25
@denis-yuen denis-yuen requested review from coverbeck, a team, david4096 and hyunnaye and removed request for a team September 17, 2024 17:25
@denis-yuen denis-yuen merged commit fc56439 into develop Sep 19, 2024
11 checks passed
@denis-yuen denis-yuen deleted the feature/touch_of_doc branch September 19, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants