Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display cost metric #1805

Merged
merged 8 commits into from
Jul 12, 2023
Merged

Display cost metric #1805

merged 8 commits into from
Jul 12, 2023

Conversation

kathy-t
Copy link
Contributor

@kathy-t kathy-t commented Jun 28, 2023

Description
This PR adds the Cost metric to the Executions Metrics table.

image

Companion PRs:

Review Instructions
See instructions in dockstore/dockstore-support#471

Issue
SEAB-5625

Security
If there are any concerns that require extra attention from the security team, highlight them here.

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that your code compiles by running npm run build
  • Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
  • If this is the first time you're submitting a PR or even if you just need a refresher, consider reviewing our style guide
  • Do not bypass Angular sanitization (bypassSecurityTrustHtml, etc.), or justify why you need to do so
  • If displaying markdown, use the markdown-wrapper component, which does extra sanitization
  • Do not use cookies, although this may change in the future
  • Run npm audit and ensure you are not introducing new vulnerabilities
  • Do due diligence on new 3rd party libraries, checking for CVEs
  • Don't allow user-uploaded images to be served from the Dockstore domain
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.
  • Check whether this PR disables tests. If it legitimately needs to disable a test, create a new ticket to re-enable it in a specific milestone.

@kathy-t kathy-t self-assigned this Jun 28, 2023
@kathy-t kathy-t changed the title Add cost metric Display cost metric Jun 28, 2023
@kathy-t kathy-t marked this pull request as ready for review June 28, 2023 15:55
@sonarcloud
Copy link

sonarcloud bot commented Jul 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

❗ No coverage uploaded for pull request base (develop@2df7676). Click here to learn what that means.
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #1805   +/-   ##
==========================================
  Coverage           ?   40.75%           
==========================================
  Files              ?      363           
  Lines              ?    11203           
  Branches           ?     2856           
==========================================
  Hits               ?     4566           
  Misses             ?     4349           
  Partials           ?     2288           
Impacted Files Coverage Δ
...pp/workflow/executions/executions-tab.component.ts 16.04% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kathy-t kathy-t merged commit 80bf62a into develop Jul 12, 2023
12 checks passed
@kathy-t kathy-t deleted the feature/seab-5625/add-cost-metric branch July 12, 2023 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants