Fix working with proxy servers #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -123,7 +124,7 @@ function read_file(success_cb, error_cb) { | |||
|
|
|||
| function download_file(callback) { | |||
| var timeouthandle = null; | |||
| console.log("%s %s:%d%s", unicodedatafile.method, unicodedatafile.host, | |||
| console.log("%s %s://%s:%d%s", unicodedatafile.method, unicodedatafile.scheme, unicodedatafile.host, | |||
There was a problem hiding this comment.
this also needs to be added below within if (proxyServer)... unicodedatafile.path = unicodedatafile.scheme + "://" + unicodedatafile.host
this would then resolve many issues on dependant projects:
dodo/node-slug#58
keystonejs/generator-keystone#129
the symptom I'm seeing is Error: Cannot find module 'unicode/category/So'
2 tasks
|
This PR is duplicates of #22 and I suggest to close. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you try to install this module using proxy, install.js will silently fail, because any normal proxy server will decline request which does not mention scheme and return HTTP 400.
This commit fixes this, this way will work either using proxy, or not.