Rating widget accessibility #281
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylans
reviewed
Apr 16, 2018
form/Rating.js
Outdated
| _onClick: function(evt) { | ||
| if (evt.target.tagName === 'LABEL') { | ||
| var clickedValue = +domAttr.get(evt.target.querySelector('input'), "value"); | ||
| // for backwards compatibility |
There was a problem hiding this comment.
backwards compatibility with previous versions of Dojo or browsers or ?
There was a problem hiding this comment.
For previous versions of Dojo, because there used to be a value attribute directly on the <li> tag. Added this in case anyone was listening to the click event and looking at evt.target.value.
There was a problem hiding this comment.
That's fine, the comment should say that so we remember what type of compatibility we were trying to preserve. :)
dylans
approved these changes
Apr 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the rating widget to use radio inputs for each star to add proper semantics and keyboard accessibility.
Resolves #280