Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(torii/graphql): cleanup names and add imagePath and metadata to erc_token #2572

Open
wants to merge 1 commit into
base: spr/main/274aaa3a
Choose a base branch
from

Conversation

@lambda-0x lambda-0x marked this pull request as draft October 23, 2024 11:35
@lambda-0x lambda-0x changed the title feat(torii/graphql): add image url and cleanup names feat(torii/graphql): cleanup names Oct 24, 2024
@lambda-0x lambda-0x force-pushed the spr/main/21a1c0a5 branch 2 times, most recently from 576733d to 9ce6a7b Compare October 24, 2024 10:11
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 18.11024% with 104 lines in your changes missing coverage. Please review.

Please upload report for BASE (spr/main/274aaa3a@0ce8f00). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...tes/torii/graphql/src/object/erc/token_transfer.rs 8.51% 43 Missing ⚠️
...ates/torii/graphql/src/object/erc/token_balance.rs 9.30% 39 Missing ⚠️
crates/torii/server/src/artifacts.rs 0.00% 9 Missing ⚠️
crates/torii/core/src/sql/erc.rs 0.00% 4 Missing ⚠️
crates/torii/graphql/src/object/erc/erc_token.rs 66.66% 4 Missing ⚠️
crates/torii/core/src/executor/mod.rs 0.00% 3 Missing ⚠️
bin/torii/src/main.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                  @@
##             spr/main/274aaa3a    #2572   +/-   ##
====================================================
  Coverage                     ?   56.57%           
====================================================
  Files                        ?      403           
  Lines                        ?    50703           
  Branches                     ?        0           
====================================================
  Hits                         ?    28683           
  Misses                       ?    22020           
  Partials                     ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lambda-0x lambda-0x changed the title feat(torii/graphql): cleanup names feat(torii/graphql): cleanup names and add imagePath and metadata to erc_token Oct 25, 2024
@lambda-0x lambda-0x marked this pull request as ready for review October 25, 2024 14:04
@lambda-0x lambda-0x force-pushed the spr/main/21a1c0a5 branch 3 times, most recently from 5c0b5cc to d8f5170 Compare October 26, 2024 15:05
@lambda-0x lambda-0x force-pushed the spr/main/21a1c0a5 branch 4 times, most recently from 7578478 to 0f3101e Compare October 30, 2024 20:06
@lambda-0x lambda-0x mentioned this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant