Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare release: v1.0.0 #2676

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Prepare release: v1.0.0 #2676

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
150 changes: 75 additions & 75 deletions Cargo.lock
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ edition = "2021"
license = "Apache-2.0"
license-file = "LICENSE"
repository = "https://github.com/dojoengine/dojo/"
version = "1.0.0-rc.2"
version = "1.0.0"

[profile.performance]
codegen-units = 1
Expand Down
2 changes: 1 addition & 1 deletion crates/dojo/core/Scarb.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ version = 1

[[package]]
name = "dojo"
version = "1.0.0-rc.0"
version = "1.0.0"
dependencies = [
"dojo_plugin",
]
Expand Down
2 changes: 1 addition & 1 deletion crates/dojo/core/Scarb.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ cairo-version = "=2.8.4"
edition = "2024_07"
description = "The Dojo Core library for autonomous worlds."
name = "dojo"
version = "1.0.0-rc.0"
version = "1.0.0"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Version inconsistencies detected across Scarb.toml files

Ohayo sensei! I found several inconsistencies in version numbers across Scarb.toml files:

  • Some files use version "1.0.0"
  • Others use "0.3.1-rc7"
  • Several use "0.1.0"
  • A couple use "1.0.0-rc.0"

These inconsistencies should be addressed to maintain version alignment across the project. Please update all Scarb.toml files to use version "1.0.0" to match the target version.

🔗 Analysis chain

Verify version consistency across the project.

Let's ensure all related files are updated to the same version.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check version consistency across Cargo.toml and Scarb.toml files
# Expected: All versions should be "1.0.0"

echo "Checking Cargo.toml versions..."
rg -g 'Cargo.toml' 'version\s*=\s*"[^"]*"' --no-filename

echo -e "\nChecking Scarb.toml versions..."
rg -g 'Scarb.toml' 'version\s*=\s*"[^"]*"' --no-filename

Length of output: 4114


[dependencies]
starknet = "=2.8.4"
Expand Down
2 changes: 1 addition & 1 deletion crates/torii/types-test/Scarb.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ version = 1

[[package]]
name = "dojo"
version = "1.0.0-rc.0"
version = "1.0.0"
dependencies = [
"dojo_plugin",
]
Expand Down
2 changes: 1 addition & 1 deletion crates/torii/types-test/Scarb.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
cairo-version = "=2.8.4"
edition = "2024_07"
name = "types_test"
version = "1.0.0-rc.0"
version = "1.0.0"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Ohayo! Version mismatch detected across packages, sensei!

The version update to "1.0.0" in crates/torii/types-test/Scarb.toml needs alignment with related core packages. Found inconsistencies:

  • crates/benches/contracts/Scarb.toml still at "1.0.0-rc.0"
  • crates/dojo/core-cairo-test/Scarb.toml still at "1.0.0-rc.0"
  • Several example packages are at different versions (0.1.0)

While the core package (crates/dojo/core/Scarb.toml) is correctly at "1.0.0", its test dependencies haven't been updated. Cairo version is consistently set to "2.8.4" across relevant packages.

🔗 Analysis chain

Ohayo! LGTM on the version update, sensei!

The version update from "1.0.0-rc.0" to "1.0.0" aligns with the release preparation objectives.

Let's verify the version alignment across related packages:

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check version consistency across Scarb.toml files
# Expected: All related packages should be updated to 1.0.0

echo "Checking version consistency across Scarb.toml files..."
fd -e toml -x grep -H "version = " {}

Length of output: 274

Script:

#!/bin/bash
# Let's try a more reliable approach to find and check versions
echo "Checking all Scarb.toml files and their versions..."
find . -name "Scarb.toml" -type f -exec sh -c 'echo "=== $1 ==="; cat "$1" | grep -E "^version = "' sh {} \;

echo -e "\nChecking cairo versions..."
find . -name "Scarb.toml" -type f -exec sh -c 'echo "=== $1 ==="; cat "$1" | grep -E "cairo-version = "' sh {} \;

Length of output: 2130


[cairo]
sierra-replace-ids = true
Expand Down
2 changes: 1 addition & 1 deletion examples/spawn-and-move/Scarb.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ dependencies = [

[[package]]
name = "dojo"
version = "1.0.0-rc.0"
version = "1.0.0"
dependencies = [
"dojo_plugin",
]
Expand Down
2 changes: 1 addition & 1 deletion examples/spawn-and-move/Scarb.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[package]
cairo-version = "=2.8.4"
name = "dojo_examples"
version = "1.0.0-rc.0"
version = "1.0.0"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Ohayo! Version inconsistency detected, sensei!

The version update to 1.0.0 in examples/spawn-and-move/Scarb.toml needs attention as we found mixed versions across the codebase:

  • Some packages are still at 1.0.0-rc.0 (e.g., crates/dojo/core-cairo-test, crates/benches/contracts)
  • Core packages have different versions (core: 1.0.0, core-cairo-test: 1.0.0-rc.0)
  • Workspace packages are using 0.1.0

Please ensure all related packages are updated consistently to avoid potential compatibility issues.

🔗 Analysis chain

Ohayo! Version update to 1.0.0 looks good, sensei!

The transition from RC to stable version aligns with the release preparation.

Let's verify version consistency across the workspace:

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check if all Scarb.toml files are updated to version 1.0.0
echo "Checking version consistency across Scarb.toml files..."
fd -e toml -x grep -l "version = " {} \; | xargs grep "version = "

Length of output: 256

Script:

#!/bin/bash
# Let's try a different approach to find Scarb.toml files and their versions
echo "Searching for all Scarb.toml files..."
fd "Scarb.toml" --type f -x cat {}

# Also search for any version-related patterns in the codebase
echo -e "\nSearching for version patterns in Scarb.toml files..."
rg "version\s*=\s*['\"]1\.0\.0" --type toml

Length of output: 6293

# Use the prelude with the less imports as possible
# from corelib.
edition = "2024_07"
Expand Down
Loading