Review app example gets now executed on every push on a PR #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
example-workflows/review-app.yaml
Outdated
Comment on lines
28
to
29
| # specify the name of the branch, in cas you do not use master | ||
| # branch: main |
There was a problem hiding this comment.
I think this should be removed tbh. There are other examples showing this. The review-app example isn't meant to be a kitchen sink, just what would make the 90% case work. If you normally deploy a different branch, then that should be configured in the app configuration (and therefore cloned). If it isn't cloned, then thats a bug in Dokku.
|
@josegonzalez I've update the PR according to your guidance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the review_app example, so it gets executed on each push.
Also added the
--forceto the example, because we do expect git to not be able to fast forward,and this will make sure the task does not fail.
Finally, bonus track, added (commented out so we stay true to the example spirit), how to overwrite the deploy branch. A classic is to use
maininstead ofmaster, so we have it there.