DIOS-6232: maxBitrate, forcePlayoutDelayMin & forcePlayoutDelayMax #201
Conversation
sheiladoherty-dolby
commented
Jul 17, 2024
•
sheiladoherty-dolby
commented
- Added maxBitrate to "More Stream Configurations" view on Landing
- Passed through maxBitrate, forcePlayoutDelayMin & forcePlayoutDelayMax to the SDK for playback
- added .DS_Store to gitignore
- some linting
LocalPackages/RTSCore/Sources/RTSCore/Models/SubscriptionConfiguration.swift
Outdated
Show resolved
Hide resolved
...nteractive Viewer/Managers/Persistence/RTSViewer.xcdatamodeld/RTSViewer.xcdatamodel/contents
Outdated
Show resolved
Hide resolved
interactive-player/Interactive Viewer/Managers/Persistence/StreamDataManager.swift
Show resolved
Hide resolved
interactive-player/Interactive Viewer/Managers/VideoTracksManager.swift
Outdated
Show resolved
Hide resolved
interactive-player/Interactive Viewer/Views/RecentStreams/RecentStreamsViewModel.swift
Show resolved
Hide resolved
...active-player/Interactive Viewer/Views/StreamDetailInputScreen/StreamDetailInputScreen.swift
Outdated
Show resolved
Hide resolved
...active-player/Interactive Viewer/Views/StreamDetailInputScreen/StreamDetailInputScreen.swift
Outdated
Show resolved
Hide resolved
...active-player/Interactive Viewer/Views/StreamDetailInputScreen/StreamDetailInputScreen.swift
Show resolved
Hide resolved
rts-viewer-ios/RTSViewer.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Hi @sheiladoherty-dolby - let's have a chat on the coding style changes that were incorporated into this PR. I used Kodeco/former Raywenderlich styles in this project. Happy to see your thoughts and the style guide you follow. Its best to not mix and match though ?
We have always used SwiftFormat for our Apple code formatting in the Denver office. It has pretty standard code practices that it formats code to & any code I touch will get formatted to these standards as I typically format the file I am working on it as I go. But if you would prefer a different method of formatting for this codebase, I can try to refrain from formatting my code with it when I am working on this codebase, although I can't make any promises as I it's become pretty automatic at this point. That said, I think our coding styles are similar enough that it doesn't really make that big a difference. |
...active-player/Interactive Viewer/Views/StreamDetailInputScreen/StreamDetailInputScreen.swift
Outdated
Show resolved
Hide resolved
...ractive-player/RTSViewer.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Outdated
Show resolved
Hide resolved
rts-viewer-ios/RTSViewer.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Outdated
Show resolved
Hide resolved
