DIOS-6236: Show Target Bitrate in Stats #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
interactive-player/Interactive Viewer/Views/SingleStream/SingleStreamViewModel.swift
Outdated
Show resolved
Hide resolved
interactive-player/Interactive Viewer/Views/StatsInfo/StatisticsInfoView.swift
Show resolved
Hide resolved
interactive-player/Interactive Viewer/Views/StatsInfo/StatsInfoViewModel.swift
Show resolved
Hide resolved
aravind-raveendran
approved these changes
Jul 24, 2024
|
May be we should follow squash commits on PRs to keep the history much cleaner !! |
bitrate for source cleanup cleanup cleanup cleanup Remove observable object
…s-app-ios-viewer into feature/targetBitrate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SingleStreamView,SingleStreamViewModel,StatisticsInfoView&StatsInfoViewModelso that theStatisticsInfoViewis no longer being reinitialized on every stat change by moving listeners toStatsInfoViewModelVideoTracksManagerto publish the targetBitrate values for all the sourceIDs.