Remove unused tx.protected() methods

dominant-strategies · Apr 30, 2024 · fe80bae · fe80bae
1 parent b94b525
commit fe80bae
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 12 deletions.
diff --git a/core/types/external_tx.go b/core/types/external_tx.go
@@ -153,7 +153,6 @@ func (tx *ExternalTx) copy() TxData {
 // accessors for innerTx.
 func (tx *ExternalTx) txType() byte                   { return ExternalTxType }
 func (tx *ExternalTx) chainID() *big.Int              { panic("external TX does not have chainid") }
-func (tx *ExternalTx) protected() bool                { return true }
 func (tx *ExternalTx) accessList() AccessList         { return tx.AccessList }
 func (tx *ExternalTx) data() []byte                   { return tx.Data }
 func (tx *ExternalTx) gas() uint64                    { return tx.Gas }

diff --git a/core/types/qi_tx.go b/core/types/qi_tx.go
@@ -88,7 +88,6 @@ func (tx *WireQiTx) copyFromWire() *QiTx {
 // accessors for innerTx.
 func (tx *QiTx) txType() byte           { return QiTxType }
 func (tx *QiTx) chainID() *big.Int      { return tx.ChainID }
-func (tx *QiTx) protected() bool        { return true }
 func (tx *QiTx) accessList() AccessList { panic("Qi TX does not have accessList") }
 func (tx *QiTx) data() []byte           { panic("Qi TX does not have data") }
 func (tx *QiTx) gas() uint64            { panic("Qi TX does not have gas") }

diff --git a/core/types/quai_tx.go b/core/types/quai_tx.go
@@ -85,7 +85,6 @@ func (tx *QuaiTx) copy() TxData {
 // accessors for innerTx.
 func (tx *QuaiTx) txType() byte              { return QuaiTxType }
 func (tx *QuaiTx) chainID() *big.Int         { return tx.ChainID }
-func (tx *QuaiTx) protected() bool           { return true }
 func (tx *QuaiTx) accessList() AccessList    { return tx.AccessList }
 func (tx *QuaiTx) data() []byte              { return tx.Data }
 func (tx *QuaiTx) gas() uint64               { return tx.Gas }

diff --git a/core/types/transaction.go b/core/types/transaction.go
@@ -468,15 +468,6 @@ func sanityCheckSignature(v *big.Int, r *big.Int, s *big.Int) error {
 	return nil
 }
 
-func isProtectedV(V *big.Int) bool {
-	if V.BitLen() <= 8 {
-		v := V.Uint64()
-		return v != 27 && v != 28 && v != 1 && v != 0
-	}
-	// anything not 27 or 28 is considered protected
-	return true
-}
-
 // Type returns the transaction type.
 func (tx *Transaction) Type() uint8 {
 	return tx.inner.txType()