Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove deploy from workflow #1059

Merged
merged 1 commit into from
Aug 28, 2023
Merged

remove deploy from workflow #1059

merged 1 commit into from
Aug 28, 2023

Conversation

robertlincecum
Copy link
Contributor

@dominant-strategies/core-dev

@Djadih
Copy link
Contributor

Djadih commented Aug 28, 2023

Pls remove dead code, otherwise looks good

gameofpointers
gameofpointers approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@gameofpointers gameofpointers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Djadih Djadih merged commit 5cb8403 into main Aug 28, 2023
1 check passed
@Djadih Djadih deleted the cicd-remove-deploy branch August 28, 2023 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Djadih Djadih Djadih approved these changes

@gameofpointers gameofpointers gameofpointers approved these changes

@wizeguyy wizeguyy Awaiting requested review from wizeguyy wizeguyy is a code owner

@kiltsonfire kiltsonfire Awaiting requested review from kiltsonfire kiltsonfire is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robertlincecum @Djadih @gameofpointers