Bug fix - Patches that went into the v0.13 tagged release #1068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gameofpointers
requested review from
wizeguyy and
kiltsonfire
as code owners
It takes sometime for all the clients to comeback up initally, So checking before using the domClient
…SetCurrentHeader Reconstruction of state was tied down to the status of the canonical hash table, since we cannot provide any guarantees on what is happening in the canonical hash table, we are collecting the blocks while traversing back and using them to construct the state tree
Previously the errors were not being caugut in the setting of the current header
If len of headers was empty and accepted was true, it would crash the node
While pruning the etx set, we have to use the block number of next block to the etx set reading block
gameofpointers
force-pushed
the
bug-fix
branch
from
df3abd6
to
d3fb501
Compare
remove GH_PAT remove gcloud auth remove kubeconfig
If state generation takes a long, time, we cannot lower the pending header that is stored on best ph key
gameofpointers
force-pushed
the
bug-fix
branch
from
d3fb501
to
bd804c1
Compare
kiltsonfire
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dominant-strategies/core-dev