Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove run-slice as an option and replace run-all with just run #1090

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Remove run-slice as an option and replace run-all with just run #1090

merged 1 commit into from
Sep 7, 2023

Conversation

Djadih
Copy link
Contributor

@Djadih Djadih commented Sep 7, 2023

@dominant-strategies/core-dev

@Djadih Djadih added documentation Improvements or additions to documentation enhancement New feature or request labels Sep 7, 2023
@Djadih Djadih self-assigned this Sep 7, 2023
@Djadih Djadih force-pushed the run-slice branch 2 times, most recently from 766f048 to dc38323 Compare September 7, 2023 19:21
wizeguyy
wizeguyy previously approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@wizeguyy wizeguyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will require some updates to documentation

@Djadih
Copy link
Contributor Author

Djadih commented Sep 7, 2023

This will require some updates to documentation

Made a slight update, but it will conflict with @maxbibeau's changes in #1089

@Djadih Djadih closed this Sep 7, 2023
@Djadih Djadih merged commit 26a7d26 into dominant-strategies:main Sep 7, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdowning100 jdowning100 jdowning100 approved these changes

@wizeguyy wizeguyy wizeguyy approved these changes

@kiltsonfire kiltsonfire Awaiting requested review from kiltsonfire kiltsonfire is a code owner

@gameofpointers gameofpointers Awaiting requested review from gameofpointers gameofpointers is a code owner

Assignees

@Djadih Djadih

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Djadih @jdowning100 @wizeguyy