Adding lock to reduce the memory pressure while synching #1104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Protecting the async updates
the zone UpdateDom takes zone pending header as input rather than entropy
…ith log of Difficutly (i.e bits)
gameofpointers
requested review from
wizeguyy and
kiltsonfire
as code owners
wizeguyy
previously approved these changes
Sep 12, 2023
Djadih
reviewed
Sep 12, 2023
Djadih
reviewed
Sep 12, 2023
Djadih
reviewed
Sep 12, 2023
Djadih
reviewed
Sep 12, 2023
Djadih
reviewed
Sep 12, 2023
Djadih
reviewed
Sep 12, 2023
Djadih
requested changes
Sep 12, 2023
GasLimit ceiling target changes based on 4 steps Each step is 150,000 blocks (i.e expected blocks for 3 weeks) GasCeil is changed to 110M because it is enough to accomodate the 1700 testnet target These changes are for the testnet and probably is not a long term controller
From simulations and rigorous testing we have understood that there is stable operating point on just using Stoichastic or using the threshold to determine Dom blocks in a Synchronous setting To be able to handle the adverse network scenarios and testnet environment and malicious miners the correct solution is mixture of having threshold to counteract malicious miners getting lucky and having a increased difficulty threshold to find a dom block
Since downloader insert is an asynchronous process, writing thousands of large blocks into the DB at the same time is very memory intensive. Adding this lock will make sure that only one block is written at a time and from the testing in the garden environment this has shown improved performance in memory use while syncing
gameofpointers
force-pushed
the
memory-pressure
branch
from
f3fb530
to
8d8c4d2
Compare
Djadih
previously approved these changes
Sep 12, 2023
gameofpointers
dismissed
Djadih’s stale review
The merge-base changed after approval.
Djadih
previously approved these changes
Sep 12, 2023
gameofpointers
dismissed
Djadih’s stale review
The merge-base changed after approval.
Djadih
previously approved these changes
Sep 12, 2023
gameofpointers
dismissed
Djadih’s stale review
The merge-base changed after approval.
gameofpointers
temporarily deployed
to
quai-sandbox
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dominant-strategies/core-dev