Adding lock to reduce the memory pressure while synching #1110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since downloader insert is an asynchronous process, writing thousands of large blocks into the DB at the same time is very memory intensive. Adding this lock will make sure that only one block is written at a time and from the testing in the garden environment this has shown improved performance in memory use while syncing
gameofpointers
requested review from
wizeguyy and
kiltsonfire
as code owners
wizeguyy
approved these changes
Sep 12, 2023
Djadih
approved these changes
Sep 12, 2023
gameofpointers
temporarily deployed
to
quai-sandbox
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dominant-strategies/core-dev