Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stateprice for Quai #2049

Merged
merged 11 commits into from
Sep 6, 2024
Merged

Stateprice for Quai #2049

merged 11 commits into from
Sep 6, 2024

Conversation

gameofpointers
Copy link
Contributor

No description provided.

@gameofpointers gameofpointers force-pushed the stateprice branch 2 times, most recently from 5a97dc7 to 47b5662 Compare August 21, 2024 20:47
@gameofpointers
Copy link
Contributor Author

gameofpointers commented Aug 21, 2024 •
edited
Loading

Fields in the header gets validated on each block, but if the functions that calculate these fields are correct is something to be tested.

Feature testing

  • Does adding new account increases the QuaiStateSize in the header?
  • Does deleting an existing account using a transaction with decreases the QuaiStateSize in the header for the next block?
  • Does adding a new storage entry into the contract increase the size of the contract account?
  • Does removing an existing storage entry from a contract decrease the size of the contract account?
  • Does the StateLimit adjust in the block based on the controller?
  • Does StateUsed reflect and is accounted for all the gas used for state computation?

wizeguyy
wizeguyy reviewed Aug 22, 2024
View reviewed changes
params/protocol_params.go Outdated Show resolved Hide resolved
@gameofpointers gameofpointers force-pushed the stateprice branch 3 times, most recently from b8b5789 to 169cdde Compare August 22, 2024 21:20
jdowning100
jdowning100 reviewed Aug 27, 2024
View reviewed changes
core/types/block.go Outdated Show resolved Hide resolved
jdowning100
jdowning100 reviewed Aug 27, 2024
View reviewed changes
Copy link
Contributor

@jdowning100 jdowning100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add stategas to create() for CreateAccount

@gameofpointers gameofpointers force-pushed the stateprice branch 3 times, most recently from 9cb95de to d0a89a0 Compare September 3, 2024 18:36
@gameofpointers
Copy link
Contributor Author

@jdowning100 made all the changes you asked. can you re review again ?

jdowning100
jdowning100 previously approved these changes Sep 3, 2024
View reviewed changes
wizeguyy
wizeguyy previously approved these changes Sep 3, 2024
View reviewed changes
@gameofpointers gameofpointers merged commit c99c37f into dominant-strategies:main Sep 6, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdowning100 jdowning100 jdowning100 approved these changes

@wizeguyy wizeguyy wizeguyy approved these changes

@kiltsonfire kiltsonfire Awaiting requested review from kiltsonfire kiltsonfire is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gameofpointers @jdowning100 @wizeguyy