Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: Add read/write lock to txSortedMap for concurrent access #2068

Closed
wants to merge 1 commit into from
Closed

Bugfix: Add read/write lock to txSortedMap for concurrent access #2068

wants to merge 1 commit into from

Conversation

jdowning100
Copy link
Contributor

@jdowning100 jdowning100 commented Aug 26, 2024 •
edited
Loading

Fixes #2054

kiltsonfire
kiltsonfire requested changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@kiltsonfire kiltsonfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should incorporate this. This is a datarace not a Panic inducing bug in the ordering of the txpool. We should ignore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiltsonfire kiltsonfire kiltsonfire requested changes

@wizeguyy wizeguyy Awaiting requested review from wizeguyy wizeguyy is a code owner

@gameofpointers gameofpointers Awaiting requested review from gameofpointers gameofpointers is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Data race in tx pool - antithesis
3 participants
@jdowning100 @kiltsonfire @rileystephens28