Clean up address errors #2087
Merged
Clean up address errors #2087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wizeguyy
requested review from
kiltsonfire and
gameofpointers
as code owners
Djadih
approved these changes
Sep 3, 2024
Is this supposed to be in this PR? |
gameofpointers
approved these changes
Sep 4, 2024
|
@jdowning100 no. We decided against it. Elsewhere in the codebase we switch on that error message. Making the error message dynamic would break those places. Refactoring those places to switch on some other logic also isn't trivial, because they did not have access to the operating context, etc. Spoke with @Juuddi about it and decided that error message was not worth the effort. |
wizeguyy
force-pushed
the
address-scope-errors
branch
from
1c385e0
to
15de623
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1994