Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed basefee and replaced with a gas price auction #2151

Merged
merged 12 commits into from
Oct 1, 2024
Merged

Removed basefee and replaced with a gas price auction #2151

merged 12 commits into from
Oct 1, 2024

Conversation

gameofpointers
Copy link
Contributor

No description provided.

jdowning100
jdowning100 reviewed Sep 26, 2024
View reviewed changes
core/types/block.go Outdated Show resolved Hide resolved
jdowning100
jdowning100 reviewed Sep 26, 2024
View reviewed changes
core/miner.go Outdated Show resolved Hide resolved
jdowning100
jdowning100 reviewed Sep 26, 2024
View reviewed changes
core/miner.go Outdated Show resolved Hide resolved
@wizeguyy
Copy link
Member

This is a significant protocol change. What's the rationale?

@gameofpointers gameofpointers force-pushed the basefee-remove branch 3 times, most recently from 0a77dac to e527565 Compare September 27, 2024 22:32
jdowning100
jdowning100 reviewed Sep 30, 2024
View reviewed changes
core/vm/evm.go Outdated Show resolved Hide resolved
jdowning100
jdowning100 reviewed Sep 30, 2024
View reviewed changes
core/worker.go Outdated Show resolved Hide resolved
jdowning100
jdowning100 reviewed Sep 30, 2024
View reviewed changes
core/worker.go Outdated Show resolved Hide resolved
jdowning100
jdowning100 reviewed Sep 30, 2024
View reviewed changes
core/worker.go Outdated Show resolved Hide resolved
jdowning100
jdowning100 reviewed Sep 30, 2024
View reviewed changes
core/worker.go Outdated Show resolved Hide resolved
@gameofpointers gameofpointers force-pushed the basefee-remove branch 2 times, most recently from 21fde85 to 63f0542 Compare September 30, 2024 15:21
@gameofpointers gameofpointers force-pushed the basefee-remove branch 2 times, most recently from 2d98c7b to bd5938d Compare September 30, 2024 22:33
wizeguyy
wizeguyy previously approved these changes Oct 1, 2024
View reviewed changes
wizeguyy
wizeguyy previously approved these changes Oct 1, 2024
View reviewed changes
@gameofpointers
Removing the protocol defined baseFee and determining baseFee from th…
10e9d2c 
…e transactions in the block
@gameofpointers
Update the genesis hash
c08e3ef
@gameofpointers
Using a uniform priced auction to reorder the transaction set to
d506620 
maximize revenue
@gameofpointers
Added EtxType and removed the IsCoinbase field from the transaction
b34ca99
@gameofpointers
Made changes to the Transaction and Receipt RPC responses
2c00565
@gameofpointers
Removed the unnecessary start function from miner
22a7672
@gameofpointers
Removed interrupt and unused method from worker
0ffb400
@gameofpointers
bugfix: Fixed the from and contract mixed address marshalling for Get…
ff7dd14 
…TransactionReceipt
@gameofpointers
Added a MinerTip api that returns the min gas price of the pool for t…
c2d332b 
…x inclusion

Also fixed the gas price api to return the minimum gas price
@gameofpointers
bugfix: Graceful shutdown of the node
33c4789
@gameofpointers gameofpointers merged commit 33c4789 into dominant-strategies:main Oct 1, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Djadih Djadih Djadih approved these changes

@wizeguyy wizeguyy wizeguyy approved these changes

@kiltsonfire kiltsonfire Awaiting requested review from kiltsonfire kiltsonfire is a code owner

@jdowning100 jdowning100 Awaiting requested review from jdowning100

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gameofpointers @wizeguyy @Djadih @jdowning100