Incrementally sorting Txs with HeapSort #2183
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Djadih
requested review from
wizeguyy,
kiltsonfire and
gameofpointers
as code owners
Djadih
force-pushed
the
txpool-sorting
branch
3 times, most recently
from
c179e29
to
15228b2
Compare
There was a problem hiding this comment.
I think the worker should be the one doing the sorting, the worker gets the pending txs from the pool, and then sorts it in time. I would also be fine if the tx pool does it, but then we have to remove the worker sorting of pending completely and rely on this. @jdowning100 do you have any other thoughts ?
|
Will be postponed until the pool is rearchitected |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.