Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject block responses if the block is not on the new fork #2322

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

gameofpointers
Copy link
Contributor

No description provided.

p2p/node/p2p_services.go Outdated Show resolved Hide resolved
Copy link
Member

@wizeguyy wizeguyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why we do this check in the request manager? This is a block validity rule, and should be checked where we check all the other block validity rules.

jdowning100
jdowning100 previously approved these changes Oct 29, 2024
@gameofpointers gameofpointers merged commit 5e83975 into dominant-strategies:main Oct 29, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants