Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic BIP47 paymentcodes implementation for Qi HD Wallet #296

Merged
merged 3 commits into from
Sep 13, 2024
Merged

Basic BIP47 paymentcodes implementation for Qi HD Wallet #296

merged 3 commits into from
Sep 13, 2024

Conversation

alejoacosta74
Copy link
Contributor

This PR adds the following new methods to QiHDWallet class:

QiHDWallet.getPaymentCode(account: number)
QiHDWallet.generateSendAddress(receiverPaymentCode: string)
QiHDWallet.generateReceiveAddress(senderPaymentCode: string)

rileystephens28
rileystephens28 reviewed Sep 13, 2024
View reviewed changes
Copy link
Member

@rileystephens28 rileystephens28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good! Unit test is working with symetric address derivation so I am happy :)

src/wallet/bip32-types.ts Outdated Show resolved Hide resolved
src/wallet/bip32-types.ts Show resolved Hide resolved
@rileystephens28 rileystephens28 merged commit 3462c30 into dominant-strategies:alpha Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rileystephens28 rileystephens28 rileystephens28 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alejoacosta74 @rileystephens28