Qi syncing and spending v2 #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
rileystephens28
commented
Oct 9, 2024
rileystephens28
commented
- improve coin selection process
- include fee in coin selection process
- fix issue where only UTXOs owned by BIP44 external addresses are spendable
- implement payment channel syncing
* refactor coin selection logic to work with denomination indices * refactor coinselector to work with UTXO objects * add new method signature for sendTransaction using paymentCodes * implement sendTransaction with paymentCode * update proto schema for Qi * WIP: add lock field and debug lines * Fix Qi tx submission * fix send Qi with musig * Remove redundent tx type population * Add qi tx fee and force denominating down for outputs * Fix signature decision in qi tx signing * Fix import without file ext * Export serialized wallet types * Remove console logs * Update external deps reference * Apply automatic changes * Apply automatic changes * Fix vulnerable dependency `rollup` * Apply automatic changes --------- Co-authored-by: Alejo Acosta <alejoacos@gmail.com> Co-authored-by: rileystephens28 <rileystephens28@users.noreply.github.com>
…f an address has been used
rileystephens28
added a commit
that referenced
this pull request
Oct 10, 2024
* implement sendTransaction with paymentCode * update proto schema for Qi * WIP: add lock field and debug lines * Fix Qi tx submission * fix send Qi with musig * bugfix: check for pubkeys equality in signTransaction * Qi gas fee (#309) * refactor coin selection logic to work with denomination indices * refactor coinselector to work with UTXO objects * add new method signature for sendTransaction using paymentCodes * implement sendTransaction with paymentCode * update proto schema for Qi * WIP: add lock field and debug lines * Fix Qi tx submission * fix send Qi with musig * Remove redundent tx type population * Add qi tx fee and force denominating down for outputs * Fix signature decision in qi tx signing * Fix import without file ext * Export serialized wallet types * Remove console logs * Update external deps reference * Apply automatic changes * Apply automatic changes * Fix vulnerable dependency `rollup` * Apply automatic changes --------- Co-authored-by: Alejo Acosta <alejoacos@gmail.com> Co-authored-by: rileystephens28 <rileystephens28@users.noreply.github.com> * Apply automatic changes * Apply automatic changes * Implement payment channel syncing mechanism and fix other syncing bugs (untested) * Create optional interface to provide external callback for checking if an address has been used * bugfix: missing address property * extend validateOutpointInfo() to check in payment code maps * bug fix in scanPaymentChannel * Fix gap sync wip * Make all utxos spendable and remove spent from set * Update script to sync after send and check receiving wallet * update Qi serialization logic * Fix send address reuse and extra change address generation * Improve selection process * WIP: add lock field and debug lines * Fix Qi tx submission * fix send Qi with musig * Remove console logs --------- Co-authored-by: Alejo Acosta <alejoacos@gmail.com> Co-authored-by: rileystephens28 <rileystephens28@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.