-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Command timetrace edit record <key>
does not rename file
#89
Comments
timetrace edit record <key>
does not rename file
Thanks for opening this issue! Since the issue that proposed the You're right that it is the same problem as with #81. I think we should take the same approach for both issues. |
So this is my suggestion to solve this:
It probably would also make sense to warn the user before the editor opens:
|
@dominikbraun Very well though out solution to this, I like it 👍 |
@dominikbraun I can handle this issue, can you assign it to me please? |
Similar to issue #81 , the
timetrace edit record <key>
command does not rename the file. This shouldn't be an issue when we pass either the--plus
or--minus
flags, since these edit the end times, but without those flags, the user can edit the json file and potentially change the start time, which is the key for a record. The documentation recommends usingtimetrace list records
in conjunction with thetimetrace edit record
command, but this does not work as intended if a flag is not used.The code expects the key to correspond to the filename, but since it is not changed, the file is not found.
In the image, I demonstrate the above with record 1. Note that this also occurs when use12Hours is false.
I'd imagine the solution would be similar to those mentioned in issue #81 .
The text was updated successfully, but these errors were encountered: