review comments

pkg/buildkit/buildkit.go

@@ -119,20 +119,20 @@ type Client struct {
 	dockerAuthConfig string
 }
 
-func validateCompression(compression hephconfig.BuildkitCompression, name string) map[string]string {
+func setCompressionAttrs(compression hephconfig.BuildkitCompression, name string) map[string]string {
 	attrs := make(map[string]string)
 	attrs["name"] = name
 	switch compression {
-	case "estargz":
+	case hephconfig.CompressionStargz:
 		attrs["push"] = "true"
 		attrs["compression"] = "estargz"
 		attrs["force-compression"] = "true"
 		attrs["oci-mediatypes"] = "true"
-	case "zstd":
+	case hephconfig.CompressionZstd:
 		attrs["compression"] = "zstd"
 		attrs["force-compression"] = "true"
 	// default is gzip
-	default:
+	case hephconfig.CompressionGzip:
 		attrs["push"] = "true"
 	}
 	return attrs
@@ -251,7 +251,7 @@ func (c *Client) Build(ctx context.Context, opts BuildOptions) error {
 		}
 	}
 	for _, name := range opts.Images {
-		bkclientattrs := validateCompression(hephconfig.CompressionMethod, name)
+		bkclientattrs := setCompressionAttrs(hephconfig.CompressionMethod, name)
 		solveOpt.Exports = append(solveOpt.Exports, bkclient.ExportEntry{
 			Type:  bkclient.ExporterImage,
 			Attrs: bkclientattrs,

pkg/config/config.go

@@ -9,7 +9,6 @@ import (
 	"strings"
 	"time"
 
-	"github.com/samber/lo"
 	"gopkg.in/yaml.v3"
 )
 
@@ -25,9 +24,6 @@ type Controller struct {
 
 func (c Controller) Validate() error {
 	var errs []string
-	var compression = []BuildkitCompression{CompressionGzip,
-		CompressionStargz, CompressionZstd}
-
 	if c.ImageBuildMaxConcurrency < 1 {
 		errs = append(errs, "imageBuildMaxConcurrency must be greater than or equal to 1")
 	}
@@ -55,11 +51,11 @@ func (c Controller) Validate() error {
 		errs = append(errs, "newRelic.licenseKey cannot be blank")
 	}
 
-	if !lo.Contains(compression, c.Buildkit.Compression) {
-		c.Buildkit.Compression = CompressionGzip
-		CompressionMethod = c.Buildkit.Compression
-	} else {
+	switch c.Buildkit.Compression {
+	case CompressionGzip, CompressionStargz, CompressionZstd:
 		CompressionMethod = c.Buildkit.Compression
+	default:
+		CompressionMethod = CompressionGzip
 	}
 
 	if len(errs) != 0 {