[PLAT-6701] Enable zstd hephaestus #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddl-retornam
force-pushed
the
retornam/heph
branch
from
d7af920
to
8b23be8
Compare
ddl-retornam
force-pushed
the
retornam/heph
branch
from
82c6834
to
b2b476f
Compare
ddl-kfrench
reviewed
Jun 28, 2023
ddl-kfrench
reviewed
Jun 28, 2023
ddl-retornam
force-pushed
the
retornam/heph
branch
from
bb09d5f
to
52b14b4
Compare
ddl-kfrench
reviewed
Jul 10, 2023
pkg/config/config.go
Outdated
| case CompressionGzip, CompressionStargz, CompressionZstd: | ||
| CompressionMethod = c.Buildkit.Compression | ||
| default: | ||
| CompressionMethod = CompressionGzip |
There was a problem hiding this comment.
do we need to ensure that gzip is forced as the default if not otherwise set? i.e.
switch c.Buildkit.Compression {
case CompressionGzip, CompressionStargz, CompressionZstd:
CompressionMethod = c.Buildkit.Compression
default:
// force gzip as the default if not otherwise set
c.Buildkit.Compression = CompressionGzip
CompressionMethod = CompressionGzip
}
ddl-kfrench
approved these changes
Jul 10, 2023
fixes issues with linter pkg/buildkit/buildkit.go:127:19: string `true` has 6 occurrences, make it a constant (goconst)
ddl-retornam
force-pushed
the
retornam/heph
branch
from
52b14b4
to
f2e30b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr creates the options to enable
zstdandestargzcompression.