Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOM-47678] Secret querying fixes #110

Merged
merged 1 commit into from
Jul 7, 2023

Commits on Jul 7, 2023

  1. [DOM-47678] Fix secret querying

     - Add secrets list perms
    
       The secret reading code had a late change to search for matching
       secrets with the correct hephaestus-accessible label instead of
       performing a simple get by namespace/name.
    
       While this prevents Hephaestus code from even accessing the secret,
       it also now requires the list permission to query secrets.
    
     - Correctly specify fields for secret name and namespace by specifying
       the metadata. prefix
    
     - Unit tests don't support the filter syntax and don't apply Kubernetes
       permissioning, and the repo functiona. tests which actually use
       Kubernetes are currently not operational, so this slipped past review
    ddl-ebrown committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    dcff29a View commit details
    Browse the repository at this point in the history