Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating stream execution with invalid credentials causes infinite loop #12

Open
Baugs opened this issue Dec 20, 2017 · 1 comment
Open

Comments

@Baugs
Copy link

Baugs commented Dec 20, 2017

The following code produces an infinite loop:

const domo = require('domo-sdk');
const domoClient = new domo.DomoClient('foo', 'bar');
domoClient.streams.createExecution('19').then((res) => {
        // Never gets here
        done();
      }).catch((err) => {
        // Never gets here either
        done(err);
      });

The logs will print the following:
GET: https://api.domo.com/oauth/token
OAuth token has likely expired. Renewing and attempting again
Renewing access token for scopes: "user data"

@walexnelson
Copy link
Contributor

Looks like the logic to limit retries was missed

https://github.com/domoinc/domo-node-sdk/blob/master/src/common/Transport.ts#L129

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants