Merge pull request #20 from donmo-roundup/fix/php7.4-compatibility

minor fixes for combatibility with php7.4
donmo-roundup · Aug 11, 2023 · 0fd568a · 0fd568a
2 parents b7e9487 + 20f2c94
commit 0fd568a
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/Model/CartDonationManagement.php b/Model/CartDonationManagement.php
@@ -11,14 +11,14 @@ class CartDonationManagement implements CartDonationManagementInterface
 {
     public function __construct(
         CartRepositoryInterface $cartRepository,
-        SerializerInterface $serializer,
+        SerializerInterface $serializer
     ) {
         $this->cartRepository = $cartRepository;
         $this->serializer = $serializer;
     }
 
     /**
-     @inheritdoc
+    @inheritdoc
      */
     public function addDonationToCart(int $cartId, float $donationAmount): string
     {
@@ -33,7 +33,7 @@ public function addDonationToCart(int $cartId, float $donationAmount): string
             } else {
                 return $this->serializer->serialize(['message' => 'Invalid donation']);
             }
-        } catch (NoSuchEntityException) {
+        } catch (NoSuchEntityException $e) {
             throw new NoSuchEntityException(__('The quote could not be loaded'));
         } catch (\Exception $e) {
             throw new \Exception('Some error has occurred');
@@ -52,7 +52,7 @@ public function removeDonationFromCart(int $cartId): string
             $this->cartRepository->save($quote);
 
             return $this->serializer->serialize(['message' => 'Success']);
-        } catch (NoSuchEntityException) {
+        } catch (NoSuchEntityException $e) {
             throw new NoSuchEntityException(__('The quote could not be loaded'));
         } catch (\Exception $e) {
             throw new \Exception('Some error has occurred');

diff --git a/Model/DonationManagement.php b/Model/DonationManagement.php
@@ -112,7 +112,7 @@ public function addDonationToCart(string $cartId, float $donationAmount): string
             } else {
                 return $this->serializer->serialize(['message' => 'Invalid donation']);
             }
-        } catch (NoSuchEntityException) {
+        } catch (NoSuchEntityException $e) {
             return $this->serializer->serialize(["message" => "The quote could not be loaded"]);
         } catch (\Exception $e) {
             return $this->serializer->serialize(["message" => "An error has occurred: " . $e->getMessage()]);
@@ -135,7 +135,7 @@ public function removeDonationFromCart(string $cartId): string
             $this->cartRepository->save($quote);
 
             return $this->serializer->serialize(['message' => 'Success']);
-        } catch (NoSuchEntityException) {
+        } catch (NoSuchEntityException $e) {
             return $this->serializer->serialize(["message" => "The quote could not be loaded"]);
         } catch (\Exception $e) {
             return $this->serializer->serialize(["message" => "An error has occurred: " . $e->getMessage()]);

diff --git a/Model/Resolver/RemoveDonationFromCart.php b/Model/Resolver/RemoveDonationFromCart.php
@@ -19,7 +19,7 @@ class RemoveDonationFromCart implements ResolverInterface
     public function __construct(
         Logger $logger,
         CartRepositoryInterface $cartRepository,
-        GetCartForUser $getCartForUser,
+        GetCartForUser $getCartForUser
     ) {
         $this->logger = $logger;
         $this->cartRepository = $cartRepository;

diff --git a/Model/Total/Donation.php b/Model/Total/Donation.php
@@ -29,7 +29,7 @@ public function collect(
         Quote $quote,
         ShippingAssignmentInterface $shippingAssignment,
         Total $total
-    ): static {
+    ) {
         parent::collect($quote, $shippingAssignment, $total);
         if (!count($shippingAssignment->getItems())) {
             return $this;