Skip to content

Commit

Permalink
Merge pull request #18 from donmo-roundup/fix/coding-standard
Browse files Browse the repository at this point in the history
fix with magento coding standard
  • Loading branch information
DavidVin357 authored Aug 11, 2023
2 parents c2bd26a + c6c1d8b commit f181006
Show file tree
Hide file tree
Showing 5 changed files with 4 additions and 8 deletions.
3 changes: 1 addition & 2 deletions Model/CartDonationManagement.php
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,7 @@ class CartDonationManagement implements CartDonationManagementInterface
public function __construct(
CartRepositoryInterface $cartRepository,
SerializerInterface $serializer,
)
{
) {
$this->cartRepository = $cartRepository;
$this->serializer = $serializer;
}
Expand Down
2 changes: 0 additions & 2 deletions Model/DonationManagement.php
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ public function __construct(
CartRepositoryInterface $cartRepository,
SerializerInterface $serializer,
MaskedQuoteIdToQuoteIdInterface $maskedQuoteIdToQuoteId

) {
$this->logger = $logger;
$this->donationFactory = $donationFactory;
Expand Down Expand Up @@ -142,5 +141,4 @@ public function removeDonationFromCart(string $cartId): string
return $this->serializer->serialize(["message" => "An error has occurred: " . $e->getMessage()]);
}
}

}
4 changes: 2 additions & 2 deletions Model/GuestCartDonationManagement.php
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
use Donmo\Roundup\Logger\Logger;
use Magento\Quote\Model\MaskedQuoteIdToQuoteIdInterface;
use Donmo\Roundup\Api\CartDonationManagementInterface;

class GuestCartDonationManagement implements GuestCartDonationManagementInterface
{
private Logger $logger;
Expand All @@ -16,8 +17,7 @@ public function __construct(
Logger $logger,
MaskedQuoteIdToQuoteIdInterface $maskedQuoteIdToQuoteId,
CartDonationManagementInterface $cartDonationManagement
)
{
) {
$this->logger = $logger;
$this->maskedQuoteIdToQuoteId = $maskedQuoteIdToQuoteId;
$this->cartDonationManagement = $cartDonationManagement;
Expand Down
1 change: 0 additions & 1 deletion Model/Resolver/AddDonationToCart.php
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@

use Magento\QuoteGraphQl\Model\Cart\GetCartForUser;


class AddDonationToCart implements ResolverInterface
{
private Logger $logger;
Expand Down
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
{
"name": "donmo-roundup/module-donations",
"type": "magento2-module",
"keywords": [
Expand Down

0 comments on commit f181006

Please sign in to comment.