Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correction of errors #1

Open
wants to merge 1 commit into
base: 7.x-1.x-donquixote-local
Choose a base branch
from

Conversation

pifagor87
Copy link
Contributor

Discovered and corrected some errors in 7.x-1.x...2259005... branch 7.x-1.x-donquixote-local
1 - as you yourself said "There is no more" Add nested box "button on the 'admin / content / nestedbox' page.", There was no "Add nested box", corrected.
2 - at removing such entity published a mistake, because there was no function nestedbox_type_form_delete_confirm, corrected.

@@ -53,7 +53,7 @@ function nestedbox_core_entity_info() {
// but without the ID suffix. (In fact, you can set
// entity_operations_entity_uri() as your URI callback, which will use the
// value here).
'path' => 'admin/content/nestedbox',
'path' => 'entity_operations_entity_uri',
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm afraid this is not how it works. This key is meant to contain a path, not a function name.

Copy link
Owner

@donquixote donquixote Aug 13, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can look at EntityOperationsDefaultUIController::__construct() to see how the 'path' is used.

@donquixote
Copy link
Owner

General comments:

I am working on the thing locally. I rebased everything onto the 2259005-8-manychanges tag, which contains more fixes.

And yes, nestedbox_type_form_delete_confirm() was missing.

@donquixote
Copy link
Owner

I will spend more time on this tomorrow.

If you want to do something: Simply write some explanations for my questions. No need to do code at this moment.

@@ -77,6 +77,7 @@ function nestedbox_core_entity_info() {
'label' => 'label',
),
'access callback' => 'nestedbox_type_access',
'static cache' => TRUE,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the doc comment on hook_entity_info(), this is TRUE by default. So no need to put it here.. right?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

 *   - static cache: (used by DrupalDefaultEntityController) FALSE to disable
 *     static caching of entities during a page request. Defaults to TRUE.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@donquixote
Copy link
Owner

Ok most of this is obsolete now, see https://github.com/donquixote/drupal-nestedbox/tree/7.x-1.x-2259005-15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants