From f942f26e415460991bd7f738c45bd18c7cd19dde Mon Sep 17 00:00:00 2001 From: Donald Raab Date: Sat, 8 Jul 2023 18:21:16 -0400 Subject: [PATCH] Remove extra test from PetKata. Signed-off-by: Donald Raab --- docs/pet-kata/slides.md | 32 ----------------- .../collections/petkata/Exercise5Test.java | 28 --------------- .../collections/petkata/Exercise5Test.java | 36 ------------------- 3 files changed, 96 deletions(-) diff --git a/docs/pet-kata/slides.md b/docs/pet-kata/slides.md index 890cc62b..3bcad21d 100644 --- a/docs/pet-kata/slides.md +++ b/docs/pet-kata/slides.md @@ -1092,38 +1092,6 @@ public void addPetAgesToExistingSet() ``` -Refactor to Eclipse Collections -------------------------------- -```java -@Test -public void refactorToEclipseCollections() -{ - // Replace List and ArrayList with Eclipse Collections types - MutableList people = Lists.mutable.with( - new Person("Mary", "Smith").addPet(PetType.CAT, "Tabby", 2), - new Person("Bob", "Smith") - .addPet(PetType.CAT, "Dolly", 3) - .addPet(PetType.DOG, "Spot", 2), - new Person("Ted", "Smith").addPet(PetType.DOG, "Spike", 4), - new Person("Jake", "Snake").addPet(PetType.SNAKE, "Serpy", 1), - new Person("Barry", "Bird").addPet(PetType.BIRD, "Tweety", 2), - new Person("Terry", "Turtle").addPet(PetType.TURTLE, "Speedy", 1), - new Person("Harry", "Hamster") - .addPet(PetType.HAMSTER, "Fuzzy", 1) - .addPet(PetType.HAMSTER, "Wuzzy", 1), - new Person("John", "Doe") - ); - - // Replace Set and HashSet with Eclipse Collections types - MutableIntSet petAges = people - .flatCollect(Person::getPets) - .collectInt(pet -> pet.getAge()) - .toSet(); - - // Extra bonus - convert to a primitive collection - Assertions.assertEquals(IntSets.mutable.with(1, 2, 3, 4), petAges); -} -``` [Exercise 5 solutions](https://github.com/eclipse/eclipse-collections-kata/tree/master/pet-kata-solutions/src/test/java/org/eclipse/collections/petkata/Exercise5Test.java) ==================== diff --git a/pet-kata-solutions/src/test/java/org/eclipse/collections/petkata/Exercise5Test.java b/pet-kata-solutions/src/test/java/org/eclipse/collections/petkata/Exercise5Test.java index 110f446b..0e13281d 100644 --- a/pet-kata-solutions/src/test/java/org/eclipse/collections/petkata/Exercise5Test.java +++ b/pet-kata-solutions/src/test/java/org/eclipse/collections/petkata/Exercise5Test.java @@ -99,32 +99,4 @@ public void findOwnerWithMoreThanOnePetOfTheSameType() Assertions.assertEquals("Harry Hamster", petOwner.getFullName()); Assertions.assertEquals("🐹 🐹", petOwner.getPets().makeString(" ")); } - - @Test - @Tag("SOLUTION") - public void refactorToEclipseCollections() - { - MutableList people = Lists.mutable.with( - new Person("Mary", "Smith").addPet(PetType.CAT, "Tabby", 2), - new Person("Bob", "Smith") - .addPet(PetType.CAT, "Dolly", 3) - .addPet(PetType.DOG, "Spot", 2), - new Person("Ted", "Smith").addPet(PetType.DOG, "Spike", 4), - new Person("Jake", "Snake").addPet(PetType.SNAKE, "Serpy", 1), - new Person("Barry", "Bird").addPet(PetType.BIRD, "Tweety", 2), - new Person("Terry", "Turtle").addPet(PetType.TURTLE, "Speedy", 1), - new Person("Harry", "Hamster") - .addPet(PetType.HAMSTER, "Fuzzy", 1) - .addPet(PetType.HAMSTER, "Wuzzy", 1), - new Person("John", "Doe") - ); - - MutableIntSet petAges = people.flatCollect(Person::getPets) - .collectInt(Pet::getAge) - .toSet(); - - //extra bonus - convert to a primitive collection - var expected = IntSets.mutable.with(1, 2, 3, 4); - Assertions.assertEquals(expected, petAges); - } } diff --git a/pet-kata/src/test/java/org/eclipse/collections/petkata/Exercise5Test.java b/pet-kata/src/test/java/org/eclipse/collections/petkata/Exercise5Test.java index 0a685e11..c4cea22f 100644 --- a/pet-kata/src/test/java/org/eclipse/collections/petkata/Exercise5Test.java +++ b/pet-kata/src/test/java/org/eclipse/collections/petkata/Exercise5Test.java @@ -95,40 +95,4 @@ public void findOwnerWithMoreThanOnePetOfTheSameType() Assertions.assertEquals("Harry Hamster", petOwner.getFullName()); Assertions.assertEquals("🐹 🐹", petOwner.getPets().makeString(" ")); } - - @Test - @Tag("KATA") - public void refactorToEclipseCollections() - { - Assertions.fail("Refactor to Eclipse Collections"); - - // Replace List and ArrayList with Eclipse Collections types - var people = new ArrayList(); - people.add(new Person("Mary", "Smith").addPet(PetType.CAT, "Tabby", 2)); - people.add(new Person("Bob", "Smith") - .addPet(PetType.CAT, "Dolly", 3) - .addPet(PetType.DOG, "Spot", 2)); - people.add(new Person("Ted", "Smith").addPet(PetType.DOG, "Spike", 4)); - people.add(new Person("Jake", "Snake").addPet(PetType.SNAKE, "Serpy", 1)); - people.add(new Person("Barry", "Bird").addPet(PetType.BIRD, "Tweety", 2)); - people.add(new Person("Terry", "Turtle").addPet(PetType.TURTLE, "Speedy", 1)); - people.add(new Person("Harry", "Hamster") - .addPet(PetType.HAMSTER, "Fuzzy", 1) - .addPet(PetType.HAMSTER, "Wuzzy", 1)); - people.add(new Person("John", "Doe")); - - // Replace Set and HashSet with Eclipse Collections types - var petAges = new HashSet(); - for (Person person : people) - { - for (Pet pet : person.getPets()) - { - petAges.add(pet.getAge()); - } - } - - //extra bonus - convert to a primitive collection - var expectedSet = Sets.mutable.with(1, 2, 3, 4); - Assertions.assertEquals(expectedSet, petAges, "Extra Credit - convert to a primitive collection"); - } }