From 2d379b37310983dbe645a2129066d9af65d9e0d7 Mon Sep 17 00:00:00 2001 From: Andrey Akinshin Date: Thu, 5 Oct 2023 15:02:44 +0200 Subject: [PATCH] Remove outlier consistency check, fix #2432 --- src/BenchmarkDotNet/Analysers/OutliersAnalyser.cs | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/src/BenchmarkDotNet/Analysers/OutliersAnalyser.cs b/src/BenchmarkDotNet/Analysers/OutliersAnalyser.cs index 6da2088e86..c5c54f8c91 100644 --- a/src/BenchmarkDotNet/Analysers/OutliersAnalyser.cs +++ b/src/BenchmarkDotNet/Analysers/OutliersAnalyser.cs @@ -22,25 +22,11 @@ protected override IEnumerable AnalyseReport(BenchmarkReport report, var workloadActual = report.AllMeasurements.Where(m => m.Is(IterationMode.Workload, IterationStage.Actual)).ToArray(); if (workloadActual.IsEmpty()) yield break; - var result = report.AllMeasurements.Where(m => m.Is(IterationMode.Workload, IterationStage.Result)).ToArray(); var outlierMode = report.BenchmarkCase.Job.ResolveValue(AccuracyMode.OutlierModeCharacteristic, EngineResolver.Instance); // TODO: improve var statistics = workloadActual.GetStatistics(); var allOutliers = statistics.AllOutliers; var actualOutliers = statistics.GetActualOutliers(outlierMode); - if (result.Length + actualOutliers.Length != workloadActual.Length) - { - // This should never happen - yield return CreateHint( - "Something went wrong with outliers: " + - $"Size(WorkloadActual) = {workloadActual.Length}, " + - $"Size(WorkloadActual/Outliers) = {actualOutliers.Length}, " + - $"Size(Result) = {result.Length}), " + - $"OutlierMode = {outlierMode}", - report); - yield break; - } - var cultureInfo = summary.GetCultureInfo(); if (allOutliers.Any()) yield return CreateHint(GetMessage(actualOutliers, allOutliers, statistics.LowerOutliers, statistics.UpperOutliers, cultureInfo), report);