Skip to content

Commit

Permalink
Added Core check with InProcess.
Browse files Browse the repository at this point in the history
  • Loading branch information
timcassell committed Dec 14, 2020
1 parent c918e15 commit 3e88680
Showing 1 changed file with 3 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -400,7 +400,9 @@ private void AssertSurvived(IToolchain toolchain, Type benchmarkType, Dictionary
{
// Core has survived memory measurement problems.
// See https://github.com/dotnet/runtime/issues/45446
if (toolchain is CsProjCoreToolchain || toolchain is CoreRtToolchain) // CoreRt actually does measure accurately in a normal benchmark run, but doesn't with the specific version used in these tests.
if (toolchain is CsProjCoreToolchain
|| (toolchain.IsInProcess && RuntimeInformation.IsNetCore)
|| toolchain is CoreRtToolchain) // CoreRt actually does measure accurately in a normal benchmark run, but doesn't with the specific version used in these tests.
return;

var config = CreateConfig(toolchain, MemoryDiagnoser.WithSurvived);
Expand Down

0 comments on commit 3e88680

Please sign in to comment.