From 3e886809ffe786478ea6793af34e6f46b84b7891 Mon Sep 17 00:00:00 2001 From: Tim Date: Sun, 13 Dec 2020 20:11:00 -0500 Subject: [PATCH] Added Core check with InProcess. --- .../BenchmarkDotNet.IntegrationTests/MemoryDiagnoserTests.cs | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/BenchmarkDotNet.IntegrationTests/MemoryDiagnoserTests.cs b/tests/BenchmarkDotNet.IntegrationTests/MemoryDiagnoserTests.cs index 635f1aa25e..a3d5bc85cb 100755 --- a/tests/BenchmarkDotNet.IntegrationTests/MemoryDiagnoserTests.cs +++ b/tests/BenchmarkDotNet.IntegrationTests/MemoryDiagnoserTests.cs @@ -400,7 +400,9 @@ private void AssertSurvived(IToolchain toolchain, Type benchmarkType, Dictionary { // Core has survived memory measurement problems. // See https://github.com/dotnet/runtime/issues/45446 - if (toolchain is CsProjCoreToolchain || toolchain is CoreRtToolchain) // CoreRt actually does measure accurately in a normal benchmark run, but doesn't with the specific version used in these tests. + if (toolchain is CsProjCoreToolchain + || (toolchain.IsInProcess && RuntimeInformation.IsNetCore) + || toolchain is CoreRtToolchain) // CoreRt actually does measure accurately in a normal benchmark run, but doesn't with the specific version used in these tests. return; var config = CreateConfig(toolchain, MemoryDiagnoser.WithSurvived);