Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't hold onto references in Consumer #2191

Merged
merged 3 commits into from
Feb 13, 2023
Merged

Don't hold onto references in Consumer #2191

merged 3 commits into from
Feb 13, 2023

Conversation

timcassell
Copy link
Collaborator

Fixes #1942

Also fixes boxing nullable value types.

@timcassell timcassell mentioned this pull request Nov 8, 2022
Closed
@timcassell
Copy link
Collaborator Author

@AndreyAkinshin Does this look okay?

AndreyAkinshin
AndreyAkinshin approved these changes Feb 13, 2023
View reviewed changes
Copy link
Member

@AndreyAkinshin AndreyAkinshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that everything is OK (at least, I wasn't able to find any regressions).

@AndreyAkinshin AndreyAkinshin merged commit ff5dbe6 into dotnet:master Feb 13, 2023
@AndreyAkinshin AndreyAkinshin added this to the v0.13.5 milestone Feb 13, 2023
@AndreyAkinshin
Copy link
Member

@timcassell thanks!

@timcassell timcassell deleted the consumer-fix branch February 13, 2023 16:28
@timcassell timcassell mentioned this pull request May 14, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreyAkinshin AndreyAkinshin AndreyAkinshin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.13.5
Development

Successfully merging this pull request may close these issues.

Consider changing Consume to not hold onto references for very long
2 participants
@timcassell @AndreyAkinshin