Fix deadlock in GetDotNetSdkVersion #2622
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
dotnet
command writes to standard error this can cause a deadlock inGetDotNetSdkVersion
.While
dotnet --version
usually does not write to standard error, this can happen if the dotnet executable is instrumented or if a custom dotnet command is used.The reason for this is that standard error is redirected but not read by GetDotNetSdkVersion, similar to #1629.
The fix is to simply not redirect standard error as it is not read anyway.