Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rowversion code sample in 8.0 what's new docs #4727

Closed
wants to merge 1 commit into from

Conversation

roji
Copy link
Member

@roji roji commented May 15, 2024

Fixes #4725

@cremor
Copy link

cremor commented May 15, 2024

This change doesn't actually improve any of my confusion described in issue #4725

Why do we need a HasConversion call? What does it do that isn't already done automatically when no HasConversion call is there at all?

@roji
Copy link
Member Author

roji commented May 24, 2024

@ajcvickers can you take a quick look at all of this when you're back?

@ajcvickers
Copy link
Member

@roji If the property is already a ulong, then specifying a conversion to ulong is pointless. If the conversion to byte[] is not now needed, that's great. I'm pretty sure last time I tested this, it was still needed in the fluent API.

@roji roji closed this Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Numeric rowversions doesn't need a HasConversion call
4 participants