Fork Xunit Console Runner to Arcade

[josalem]

This issue is for tracking work on forking the xunit console runner.

Reason

The current xunit console runner (v2.4.x) is no longer maintained, so we will be forking the code for longer term maintenance and feature updates until a viable alternative presents itself.

TODO

• Initial Code push
• Infrastructure for consuming NuGet (covered by Arcade as far as I know)
• Planning on ownership, feature addition, etc.
• Incorporate changes from Add XUnitFilter wrapper to exclude Methods, Classes and Namespaces buildtools#2035
• Exception in test infrastructure - System.InvalidOperationException: Collection was modified after the enumerator was instantiated runtime#11063

CC - @ViktorHofer

[josalem]

@BruceForstall

[BruceForstall]

cc @echesakovMSFT

[BruceForstall]

cc @RussKeldorph

[echesakov]

@jashook @sbomer

[jashook]

Adding more people who may be interested @dotnet/jit-contrib @safern

[safern]

cc: @danmosemsft

[BruceForstall]

@ViktorHofer @josalem Now that #1627 is merged, what is the plan for addressing the bugs/issues referenced above?

[josalem]

There isn't a plan in place yet. We could create a label for xunit runner issues and create issues/PRs with that label. That will give us a nice view of what work needs to be done since I'm sure I'm missing a few in the checklist above. I was planning on tackling the response files work (dotnet/buildtools#2035) that @A-And added to the old custom runner in the near future.

[ViktorHofer]

We aren't using this runner in corefx for netcoreapp and netfx right now as there is no necessity to do so but if it's blocking when can switch over to it. Right now we use a repackaged version of it for uap (UWP console app) and uapaot (netcoreapp2.0 + WINDOWS_UWP constant).

[echesakov]

@josalem @ViktorHofer Can you please tell how far we are from getting this fork published to NuGet?

I have a fix xunit/xunit#1846 that I would like port to the fork and consume the fork version of xunit.console.dll in coreclr when publishing jobs to Helix.

[echesakov]

/cc @RussKeldorph

[josalem]

As far as I'm aware, this should already be available as a pacakge on the NuGet feed that Arcade puts its build outputs in (based on this doc). It should be in the dotnet-feed NuGet feed.

Should be under the name Microsoft.DotNet.XUnitConsoleRunner at version 2.5.0. It still outputs xunit.console.dll, so scripts shouldn't need to change, just the package name.

[echesakov]

@josalem Thanks!

[josalem]

Is this issue needed anymore? I think the work above was completed a long while ago.

[ViktorHofer]

Thanks, closing.