Adding fork of xunit.console #1627
Conversation
|
@josalem Is this ready to go, modulo reviews? @ViktorHofer ping |
|
As far as I'm aware, this should be good to go sans any issues brought up by review. My understanding is that Arcade's build should handle turning this into a nupkg available on the blob feed, so all that's left is reviewing the changes. |
|
@ViktorHofer, @markwilkie, is there anything specific that needs to be done before this PR can be accepted? Thank you! |
|
Thanks. I'll review the PR later today. |
|
Quick question, why does it generate a |
|
I modified the name to differentiate from the official XUnit console runner they still have hosted on NuGet. Mainly so we are not publishing a package with the same name and being construed as the official XUnit console runner. It's a superficial change, so it would be trivial to change it back. |
|
I would prefer if we keep the official assembly name and only change the package name. |
|
Looking now... |
|
Do we really need the netcoreapp1.0 build configuration? |
src/Microsoft.DotNet.XUnitConsoleRunner/src/Sinks/DiagnosticMessageSink.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.DotNet.XUnitConsoleRunner/src/Sinks/MarshalByRefObject.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.DotNet.XUnitConsoleRunner/src/Utility/ConsoleLogger.cs
Outdated
Show resolved
Hide resolved
|
@josalem I removed other unused code (+ partially remaining netfx ifdefs). We are still adding 5.5k lines to arcade which is the bare minimum as I believe. I'm now experimenting if I can combine the Microsoft.DotNet.XUnitRunnerUap with this package. |
ViktorHofer
force-pushed
the
xunit-console-runner
branch
from
a090ef5
to
b7bf4c4
Compare
* Had to comment out xunit assembly names since it looks like Arcade adds its own * Replaced project references with the appropriate package references
…ense: * Modified name of assembly to xunit.console.netcore to differentiate from xunit.console NuGet pacakge * moved source into Microsoft.DotNet.XUnitConsoleRunner * Added attributions to README for project dir
ViktorHofer
force-pushed
the
xunit-console-runner
branch
from
b7bf4c4
to
5ed16c3
Compare
|
I'm done with the required work. We are now using the sources here for different variations of the runner (netcoreapp2.0, uap, uapaot), I'm very happy about that. Tested locally and everything works as expected. |
ViktorHofer
force-pushed
the
xunit-console-runner
branch
from
5ed16c3
to
8099366
Compare
|
Thanks a lot @josalem for your work! |
|
@ViktorHofer, @josalem, thank you so much! |
|
Are we now using this for corefx test runs (and others)? cc @echesakovMSFT |
This PR adds a fork of the xunit console runner (v2.4.1) to Arcade. The console runner for v2 of xunit is no longer being maintained, so this will provide a centralized source for long term maintenance and feature addition until a more viable solution, e.g., a backwards-compatible v3 of xunit, comes along.
The source code under
src/Microsoft.DotNet.XUnitConsoleRunnergenerates axunit.console.netcore.dllthat can be used in the same way as thexunit.console.runnernuget package'sxunit.console.dll.#1613