Skip to content

Commit

Permalink
[release/9.0] Fix skip condition for IIS tests (#57999)
Browse files Browse the repository at this point in the history
* Fix skip condition for IIS tests

* Update StartupTests.cs

* Update StartupTests.cs
  • Loading branch information
wtgodbe authored Sep 23, 2024
1 parent c68cfd0 commit 6bbc4f1
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ namespace Microsoft.AspNetCore.Server.IIS.FunctionalTests;
#endif

[Collection(IISSubAppSiteCollection.Name)]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Pre.Open;")]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Pre.Open;" + "Windows.Amd64.VS2022.Pre;")]
public class RequestPathBaseTests : FixtureLoggedTest
{
private readonly IISSubAppSiteFixture _fixture;
Expand All @@ -32,7 +32,7 @@ public RequestPathBaseTests(IISSubAppSiteFixture fixture) : base(fixture)
}

[ConditionalTheory]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Pre.Open;")]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Pre.Open;" + "Windows.Amd64.VS2022.Pre;")]
[RequiresNewHandler]
[InlineData("/Sub/App/PathAndPathBase", "/Sub/App/PathAndPathBase", "")]
[InlineData("/SUb/APp/PathAndPAthBase", "/SUb/APp/PathAndPAthBase", "")]
Expand All @@ -53,7 +53,7 @@ public async Task RequestPathBase_Split(string url, string expectedPathBase, str
}

[ConditionalTheory]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Pre.Open;")]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Pre.Open;" + "Windows.Amd64.VS2022.Pre;")]
[RequiresNewHandler]
[InlineData("//Sub/App/PathAndPathBase", "//Sub/App/PathAndPathBase", "")]
[InlineData(@"/\Sub/App/PathAndPathBase/", @"/\Sub/App/PathAndPathBase", "/")]
Expand Down
4 changes: 2 additions & 2 deletions src/Servers/IIS/IIS/test/Common.LongTests/StartupTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ namespace Microsoft.AspNetCore.Server.IIS.FunctionalTests;

// Contains all tests related to Startup, requiring starting ANCM/IIS every time.
[Collection(PublishedSitesCollection.Name)]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Pre.Open;")]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Pre.Open;" + "Windows.Amd64.VS2022.Pre;")]
public class StartupTests : IISFunctionalTestBase
{
public StartupTests(PublishedSitesFixture fixture) : base(fixture)
Expand Down Expand Up @@ -1297,7 +1297,7 @@ public async Task PreferEnvironmentVariablesOverWebConfigWhenConfigured(HostingM
[ConditionalFact]
[RequiresNewHandler]
[RequiresNewShim]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Pre.Open;")]
[SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Pre.Open;" + "Windows.Amd64.VS2022.Pre;")]
public async Task ServerAddressesIncludesBaseAddress()
{
var appName = "\u041C\u043E\u0451\u041F\u0440\u0438\u043B\u043E\u0436\u0435\u043D\u0438\u0435";
Expand Down

0 comments on commit 6bbc4f1

Please sign in to comment.