-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[main] Update dependencies from dotnet/runtime #47021
Changes from all commits
bbfb501
a3d5075
9415a5a
a87de23
ae7ba0c
6930fd5
e7d25ec
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1723,4 +1723,11 @@ namespace Microsoft.AspNetCore.Http.Generated | |
return T.BindAsync(context, parameter); | ||
} | ||
} | ||
|
||
%GENERATEDCODEATTRIBUTE% | ||
file static class ParsableHelper<T> where T : IParsable<T> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we only generate this when we have to? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think it should be fine as a stop gap, I think we should actually try to get the runtime to extend public static bool TryParseExplicit<T>(string? s, IFormatProvider? provider, out T result) where T: IParsable<T>
{
return T.TryParse(s, provider, out result!);
} Just so people have a simple way of calling the explicit interface without having to write boilerplate like the above everywhere. |
||
{ | ||
public static T Parse(string s, IFormatProvider? provider) => T.Parse(s, provider); | ||
public static bool TryParse(string? s, IFormatProvider? provider, [MaybeNullWhen(returnValue: false)] out T result) => T.TryParse(s, provider, out result); | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When do we ever call the
Parse
method?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not strictly needed. We'd probably be fine code-genning something lighter like
TryParseExplicit
.Also, I had forgotten that these Maestro PRs automerge once the build is green. 🤦🏽♀️ I'll have to address your feedback in a follow-up.