Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add amendable OverscanCount parameter to the QuickGrid for virtualization. #55078

Merged
merged 13 commits into from
Apr 22, 2024

Conversation

MattyLeslie
Copy link
Contributor

@MattyLeslie MattyLeslie commented Apr 11, 2024

QuickGrid: Add OverscanCount Parameter (#49263)

Summary of Changes:
The addition of an OverscanCount parameter to the QuickGrid component. This parameter directly interfaces with the pre-existing OverscanCount property within the Virtualize component during initialization.

Description:
In contrast to the unmodifiable overscan property within the Virtualize component, this enhancement allows for the QuickGrid component to expose a configurable property named OverscanCount. Upon initialization, this property updates the existing OverscanCount attribute within the Virtualize component. The default value remains consistent at "3".

Fixes
#49263 by introducing the OverscanCount property within the QuickGrid component and initializing the Virtualize component with the specified OverscanCount value.

@MattyLeslie MattyLeslie requested a review from a team as a code owner April 11, 2024 11:23
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-blazor Includes: Blazor, Razor Components label Apr 11, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Apr 11, 2024
@MattyLeslie
Copy link
Contributor Author

@MattyLeslie please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@dotnet-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@dotnet-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@dotnet-policy-service agree company="Microsoft"

Contributor License Agreement

@dotnet-policy-service agree company="Retro Rabbit"

@MattyLeslie MattyLeslie changed the title #49263 Add amendable OverscanCount parameter to the QuickGrid for virtualization. Apr 16, 2024
@MattyLeslie
Copy link
Contributor Author

@SteveSandersonMS May I request a review for this please. I may need some feedback on the API changes. Thanks in advance.

@SteveSandersonMS
Copy link
Member

@MattyLeslie Certainly, thanks for the prompt.

This looks great. As long as the build passes I think we can accept this as-is.

@SteveSandersonMS SteveSandersonMS enabled auto-merge (squash) April 22, 2024 12:57
@MattyLeslie
Copy link
Contributor Author

@SteveSandersonMS Great to hear, thanks for the review !

Copy link
Member

@SteveSandersonMS SteveSandersonMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much!

@SteveSandersonMS SteveSandersonMS merged commit aed195f into dotnet:main Apr 22, 2024
26 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0-preview4 milestone Apr 22, 2024
@MattyLeslie MattyLeslie deleted the 49263 branch May 15, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-blazor Includes: Blazor, Razor Components community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants