Allow ShowColumnOptionsAsync method to accept null parameter #56991
Conversation
dotnet-issue-labeler
bot
added
the
area-blazor
dotnet-policy-service
bot
added
the
community-contribution
|
Thanks for your PR, @spdebeer. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
|
I see that the tests are unhappy with the modification I made to the PublicAPI.Shipped.txt file, I am however not sure how to proceed without that modification, the build seems to fail without it, having the updated method signature in the Unshipped file alone seems to not be enough. Any guidance or recommendations will be appreciated. |
|
Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime. |
dotnet-policy-service
bot
added
the
pending-ci-rerun
|
hi @MackinnonBuck, could you please have a look for me, would be much appreciated |
| @@ -264,7 +264,7 @@ public Task SortByColumnAsync(ColumnBase<TGridItem> column, SortDirection direct | |||
| /// options UI that was previously displayed. | |||
| /// </summary> | |||
| /// <param name="column">The column whose options are to be displayed, if any are available.</param> | |||
| public Task ShowColumnOptionsAsync(ColumnBase<TGridItem> column) | |||
| public Task ShowColumnOptionsAsync(ColumnBase<TGridItem>? column) | |||
| { | |||
| _displayOptionsForColumn = column; | |||
| _checkColumnOptionsPosition = true; // Triggers a call to JS to position the options element, apply autofocus, and any other setup | |||
There was a problem hiding this comment.
If called with null, this is still going to set _checkColumnOptionsPosition to true, resulting in unnecessary interop.
I'd suggest just exposing CloseColumnOptions instead.
Edit: I've PR'd that here: #57904
Allow ShowColumnOptionsAsync method to accept null parameter
Description
Allow the
ColumnBase<TGridItem>parameter passed into theShowColumnOptionsAsyncmethod to be NULLFixes #54357