Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .NET SDK to 9.0.100-rc.2.24468.2 #58028

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Updates the .NET SDK to version 9.0.100-rc.2.24468.2, which also updates the .NET runtime from version 9.0.0-rc.2.24456.9 to version 9.0.0-rc.2.24463.7.

This pull request was auto-generated by GitHub Actions.

Update .NET SDK to version 9.0.100-rc.2.24468.2.

---
updated-dependencies:
- dependency-name: Microsoft.NET.Sdk
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot requested review from wtgodbe and a team as code owners September 23, 2024 12:12
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Sep 23, 2024
Copy link
Contributor

@dotnet-policy-service dotnet-policy-service bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving SDK update.

@wtgodbe wtgodbe requested a review from a team as a code owner September 23, 2024 16:45
@@ -47,4 +47,10 @@
<!-- Transitive dependency of System.Security.Cryptography.Pkcs.5.0.*. -->
<UsagePattern IdentityGlob="System.Formats.Asn1/6.0.0" />
</IgnorePatterns>

<!-- Transitive dependencies, suppressed as per https://github.com/dotnet/aspnetcore/pull/57887#issuecomment-2362241518-->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dotnet/source-build-contrib

Do we need a tracking issue for this? Do we know why/how the behavior changed?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ellahathaway - Can you respond here since you had investigated this in #57887 (comment)?

Copy link
Member

@ellahathaway ellahathaway Sep 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a tracking issue for this?

I don't think that a tracking issue is necessary here. On the condition that these prebuilts do cause failures in the VMR, source-build will see those failures in our pipelines, file an issue in the source-build repo, and I can follow up there. Unless that happens, I don't see a need to write up a tracking issue until there is some (if any) action to take.

Do we know why/how the behavior changed?

Unfortunately, no. The binlogs were not helpful in diagnosing the issue, but we found packages (that were already listed in the exclusion baseline) in the prebuilt report that are known parents of these dependencies. Based on that, we made an educated guess that these prebuilts likely surfaced due to changes in how nuget handles transitive dependencies.

@wtgodbe wtgodbe merged commit 58c31cd into main Sep 23, 2024
27 checks passed
@wtgodbe wtgodbe deleted the update-dotnet-sdk-9.0.100-rc.2.24468.2 branch September 23, 2024 22:59
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview1 milestone Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework Type: Dependency Update 🔼
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants