Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update .NET SDK to 9.0.100-rc.2.24468.2 #58028

Merged
merged 2 commits into from
Sep 23, 2024
+8 −2
Merged

Update .NET SDK to 9.0.100-rc.2.24468.2 #58028

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
08ae498
Update .NET SDK
github-actions[bot] Sep 23, 2024
85330d9
Update SourceBuildPrebuiltBaseline.xml
wtgodbe Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions eng/SourceBuildPrebuiltBaseline.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,4 +47,10 @@
<!-- Transitive dependency of System.Security.Cryptography.Pkcs.5.0.*. -->
<UsagePattern IdentityGlob="System.Formats.Asn1/6.0.0" />
</IgnorePatterns>

<!-- Transitive dependencies, suppressed as per https://github.com/dotnet/aspnetcore/pull/57887#issuecomment-2362241518-->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dotnet/source-build-contrib

Do we need a tracking issue for this? Do we know why/how the behavior changed?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ellahathaway - Can you respond here since you had investigated this in #57887 (comment)?

Copy link
Member

@ellahathaway ellahathaway Sep 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a tracking issue for this?

I don't think that a tracking issue is necessary here. On the condition that these prebuilts do cause failures in the VMR, source-build will see those failures in our pipelines, file an issue in the source-build repo, and I can follow up there. Unless that happens, I don't see a need to write up a tracking issue until there is some (if any) action to take.

Do we know why/how the behavior changed?

Unfortunately, no. The binlogs were not helpful in diagnosing the issue, but we found packages (that were already listed in the exclusion baseline) in the prebuilt report that are known parents of these dependencies. Based on that, we made an educated guess that these prebuilts likely surfaced due to changes in how nuget handles transitive dependencies.

<Usages>
<Usage Id="Newtonsoft.Json" Version="13.0.1" />
<Usage Id="System.Security.Cryptography.Xml" Version="6.0.0" />
</Usages>
</UsageData>
4 changes: 2 additions & 2 deletions global.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
{
"sdk": {
"version": "9.0.100-rc.2.24459.3"
"version": "9.0.100-rc.2.24468.2"
},
"tools": {
"dotnet": "9.0.100-rc.2.24459.3",
"dotnet": "9.0.100-rc.2.24468.2",
"runtimes": {
"dotnet/x86": [
"$(MicrosoftNETCoreBrowserDebugHostTransportVersion)"
Expand Down
Loading