Use ImpersonationToken for IIS Windows Auth #58041
Open
+55
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrennanConroy
added
feature-iis
BrennanConroy
requested review from
halter73,
JamesNK and
mgravell
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #54175
The doc comments on
GetPrimaryTokenandGetImpersonationTokenare next to useless so can't really comment on the difference between them. However, did look at the old .NET FX IIS code and it was usingGetImpersonationTokenso I feel a bit better about this change.Looks like the same sort of issue is filed on corewcf as well CoreWCF/CoreWCF#757
cc @mconnew