Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GetGeneration breaking change #35228

Merged
merged 1 commit into from
May 4, 2023
Merged

GetGeneration breaking change #35228

merged 1 commit into from
May 4, 2023

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented May 2, 2023 •
edited by github-actions bot
Loading

@dotnet-bot dotnet-bot added this to the May 2023 milestone May 2, 2023
@ghost ghost added the 🏁 Release: .NET 8 Work items for the .NET 8 release label May 2, 2023
@gewarren gewarren requested review from EgorBo and a team May 2, 2023 22:05
BillWagner
BillWagner approved these changes May 4, 2023
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @gewarren

Let's :shipit:

@gewarren gewarren merged commit 6e8f593 into dotnet:main May 4, 2023
@gewarren gewarren deleted the getgeneration branch May 4, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillWagner BillWagner BillWagner approved these changes

@EgorBo EgorBo EgorBo approved these changes

Assignees
No one assigned
Labels
🏁 Release: .NET 8 Work items for the .NET 8 release dotnet-fundamentals/svc
Projects
No open projects
.NET 8.0 work items
Status: ✅ Done
Milestone
May 2023
Development

Successfully merging this pull request may close these issues.

[Breaking change]: GC.GetGeneration may return int.MaxValue for certain types of objects
4 participants
@gewarren @BillWagner @EgorBo @dotnet-bot