Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Two core library breaking changes #42833

Merged
merged 3 commits into from
Oct 4, 2024
Merged

Two core library breaking changes #42833

merged 3 commits into from
Oct 4, 2024

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Oct 4, 2024 •
edited by github-actions bot
Loading

@gewarren gewarren requested a review from a team as a code owner October 4, 2024 01:19
BillWagner
BillWagner approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, once you fix the build warnings.

@gewarren gewarren enabled auto-merge (squash) October 4, 2024 17:08
@gewarren gewarren merged commit 6471416 into dotnet:main Oct 4, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillWagner BillWagner BillWagner approved these changes

@bartonjs bartonjs Awaiting requested review from bartonjs

@jozkee jozkee Awaiting requested review from jozkee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@gewarren @BillWagner